#Xnviewmp filters code

I did raise an issue before the code freeze for darktable 4.0 and there is some useful discussion there. I think my main issue is with the UI of the “range” filters (particularly the rating range filter). But we remove the quick access duplicated filters at the top of the pictures grid since its true value is arguably debatable. So, my proposal (opened for discussion) would be to remove the filtering mechanism from the collection panel, keep the collection filters panel (this way we remove similar duplicated capabilities and we have a more “open” (“aéré”) way to display filters). So I come to the conclusion that there is no real added value in being able to display the duplicated filters at the top of the pictures grid. And since the space is rather limited at the top of the pictures grid, we cant anyway add too many filters. It is because in practice, I tend to think we use quite few filters and in that case going directly to the collection filters panel is also very quick. And since it can anyway be disabled by unpinning the filter, we may think it is actually a good idea. I concede that if you have many filters, the access is maybe less direct in the collection filter panel. The idea I think is to provide quick access to some filters.

What is new though is the fact that you can select which filter is “duplicated” at the top of the pictures grid. As far as I can see, there is no additional features offered by the collection filters panel (am I right ? ) regarding filtering itself. Now, with this new collection filtering panel, we also have a filtering mechanism, but presented differently. We can filter according to a huge array of features, quite amazing ! In the collection panel, we have already a powerful filtering mechanism, already present in 3.8. So from my perspective, I see an inconsistency with the new collection filter and the collection panel itself. All opinions are welcome, as long as “civility” and respect is fully maintained. Lets just base our statements on logic and rationality, whenever possible, and have a friendly attitude. My goal is that together, we try to reach a common conclusion about if this is useful or not, and more importantly “why”. I propose a discussion on the “relevance” of the new collection filters.

Xnviewmp filters